mirror of
https://scm.tikali.ai/tikali/applications/monky/monky-deployd.git
synced 2026-09-18 04:36:15 +00:00
mdella
43615a6fda
Three faults from one agent-managed onboarding (env-dev-08, 2026-09-09), each of which pointed the diagnosis away from the actual fault. 1. install.sh granted the agent's read on the ziti identity with a POSIX ACL. ziti-edge-tunnel rewrites that file on a controller config update and the rewrite drops the ACL: the agent applied cleanly at 01:21 and was failing every tick by 01:32. Group membership survives the rewrite (the file stays ziti:ziti 0640), so install.sh and the package postinstall now add monky-deployd to the `ziti` group, and a default ACL on the identity directory carries the grant onto a newly created file. The explicit ACLs stay for the boxes that need them. 2. openziti.load() accepts an unreadable or malformed identity: the C SDK logs "configuration is invalid" and returns a context that only fails at dial, as a bare TypeError, which the transport reported as a missing intercept or a policy gap. The SDK transport now reads and parses the identity itself and names the real fault first. 3. The disk pre-flight ran only when the bundle declared disk_need_bytes, so a bundle without one died mid-pull with containerd's "no space left on device" — which reads as a registry fault. A bundle that declares no size now has to clear the headroom floor, and the pre-flight measures containerd's root as well as the docker data-root: docker 29 keeps image layers in the containerd image store, and on env-dev-08 those sat on different filesystems (93 GiB free where the agent looked, 2.8 GiB where the pull wrote). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KLB7jieMNRkTsJ2epr4Ds1
60 lines
2.1 KiB
Python
60 lines
2.1 KiB
Python
"""Free-space accounting across the filesystems a pull can fill.
|
|
|
|
docker 29 keeps image layers in containerd's store, which is frequently on a different
|
|
filesystem than DockerRootDir. env-dev-08 (2026-09-09) had 93 GiB free on the data-root and
|
|
2.8 GiB on the filesystem containerd was writing to; the pull died with "no space left on
|
|
device" after the pre-flight had reported plenty of room.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import monky_deployd.compose as compose_mod
|
|
from monky_deployd.compose import Docker
|
|
|
|
|
|
class _FixedDocker(Docker):
|
|
def __init__(self, root: str):
|
|
super().__init__()
|
|
self._root = root
|
|
|
|
def data_root(self) -> str:
|
|
return self._root
|
|
|
|
|
|
def test_storage_paths_include_containerd_root_when_present(tmp_path, monkeypatch):
|
|
root = tmp_path / "docker"
|
|
containerd = tmp_path / "containerd"
|
|
root.mkdir()
|
|
containerd.mkdir()
|
|
monkeypatch.setattr(compose_mod, "CONTAINERD_ROOTS", (str(containerd),))
|
|
assert _FixedDocker(str(root)).storage_paths() == [str(root), str(containerd)]
|
|
|
|
|
|
def test_storage_paths_skip_a_containerd_root_that_does_not_exist(tmp_path, monkeypatch):
|
|
root = tmp_path / "docker"
|
|
root.mkdir()
|
|
monkeypatch.setattr(compose_mod, "CONTAINERD_ROOTS", (str(tmp_path / "absent"),))
|
|
assert _FixedDocker(str(root)).storage_paths() == [str(root)]
|
|
|
|
|
|
def test_free_bytes_reports_the_tightest_filesystem(tmp_path, monkeypatch):
|
|
root = tmp_path / "docker"
|
|
containerd = tmp_path / "containerd"
|
|
root.mkdir()
|
|
containerd.mkdir()
|
|
monkeypatch.setattr(compose_mod, "CONTAINERD_ROOTS", (str(containerd),))
|
|
d = _FixedDocker(str(root))
|
|
monkeypatch.setattr(d, "_free_at", lambda p: 900 if p == str(root) else 5)
|
|
assert d.free_bytes() == 5
|
|
# an explicit path is still measured on its own
|
|
assert d.free_bytes(str(root)) == 900
|
|
|
|
|
|
def test_free_bytes_is_none_when_nothing_can_be_measured(tmp_path, monkeypatch):
|
|
root = tmp_path / "docker"
|
|
root.mkdir()
|
|
monkeypatch.setattr(compose_mod, "CONTAINERD_ROOTS", ())
|
|
d = _FixedDocker(str(root))
|
|
monkeypatch.setattr(d, "_free_at", lambda p: None)
|
|
assert d.free_bytes() is None
|